Corrected bit checks due to reverse ordered bits#879
Merged
rhoneyager merged 5 commits intodevelopfrom Mar 22, 2022
Merged
Conversation
Contributor
|
Hi, @haydenlj! Thanks for adding me here. I'll add @BenjaminRuston too. |
Contributor
|
I believe the PR is good to go (removing the draft). The CI tests are failing, probably because the reference file needs to be updated. |
BenjaminRuston
approved these changes
Mar 21, 2022
Contributor
|
The CI tests are failing due to the coding norms with the following message: If you run |
Co-authored-by: Fabio L R Diniz <45880035+fabiolrdiniz@users.noreply.github.com>
huishao-r
reviewed
Mar 22, 2022
| testinput/aeronet_tab.dat | ||
| testinput/imsscf_20191215_c48.nc | ||
| testinput/bfrPrf_C2E3.2020.349.21.26.R18_0001.0001_bufr | ||
| testinput/bfrPrf_C2E6.2021.214.12.00.G16_0001.0001_bufr |
Collaborator
There was a problem hiding this comment.
is this data uploaded to data repo already?
Contributor
There was a problem hiding this comment.
ioda-converters has no ioda-converters-data repository. So, yes, the data are already uploaded.
huishao-r
approved these changes
Mar 22, 2022
huishao-r
reviewed
Mar 22, 2022
| @@ -180,14 +184,15 @@ def get_obs_data(bufr, profile_meta_data, record_number=None): | |||
| bang_conf = codes_get_array(bufr, 'percentConfidence')[1:krepfac[0]+1] | |||
Collaborator
There was a problem hiding this comment.
Should this be checked as one of the QC flags so that it can be consistent with the Fortran code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrected bit check due to reverse ordered bits in QC word
Issue(s) addressed
Link the issues to be closed with this PR
Acceptance Criteria (Definition of Done)
Code runs and correctly decodes QC bits