-
Notifications
You must be signed in to change notification settings - Fork 15
Feature/argo clim2ioda changes ne #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhoneyager
merged 11 commits into
feature/sprint-ioda-converters
from
feature/argoClim2ioda_changes_NE
Mar 22, 2022
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
87a1de3
updates so far
nicholasesposito cd34dce
Merge branch 'develop' of https://github.com/JCSDA-internal/ioda-conv…
nicholasesposito 3bd7cc6
argoClim2ioda.py updates
nicholasesposito 8783acb
Merge branch 'develop' of https://github.com/JCSDA-internal/ioda-conv…
nicholasesposito a59a613
update testoutput because of dateTime int changes
nicholasesposito 2be6ef3
Merge branch 'feature/sprint-ioda-converters' into feature/argoClim2i…
nicholasesposito e63f580
update to testoutput
nicholasesposito d5f3f7e
Merge branch 'feature/sprint-ioda-converters' into feature/argoClim2i…
srherbener 909f85e
Merge branch 'feature/sprint-ioda-converters' into feature/argoClim2i…
srherbener 2233b61
Merge branch 'feature/sprint-ioda-converters' into feature/argoClim2i…
srherbener 7f8cff6
Merge branch 'feature/sprint-ioda-converters' into feature/argoClim2i…
rhoneyager File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git LFS file not shown
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input file
testinput/argoclim_test.ncalready has the variableTIMEwith an attribute forunitsset tomonths since 2004-01-01 00:00:00. IODA cannot really handle themonths sinceyet and would really needseconds sincebut it could be possible to bypass a lot of date manipulation happening inside this code with some potential manipulations of the Epoch and values inTIMEto conform to IODA. Perhaps we can leave this alone right now, but I see potential for beneficial changes in this area.