changes for L2 trace gas varnames to follow conventions#1145
Merged
srherbener merged 3 commits intofeature/sprint-ioda-convertersfrom Jan 12, 2023
Merged
Conversation
jeromebarre
changed the base branch from
develop
to
feature/sprint-ioda-converters
mer-a-o
approved these changes
Jan 12, 2023
srherbener
reviewed
Jan 12, 2023
Collaborator
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Changes look good. The tropomi tests are still commented out, ie not running. Is that what we want, or should we uncomment and enable the tests? Thanks!
Author
|
@srherbener I just uncommented the tests now. They are working fine. |
Collaborator
|
@jeromebarre I created feature/sprint-ioda-converters-jerome2 branches (based on feature/sprint-ioda-converters) for both ioda and ioda-data repos. The ctests were failing because these branches did not exist and develop was selected for both ioda and ioda-data. ctest results this time should look much better. |
srherbener
approved these changes
Jan 12, 2023
Collaborator
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Thanks for uncommenting the tropomi tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes for L2 trace gas varnames to follow conventions