make L2 trace gas converters work and be consistent with what the upgrader#1142
Merged
BenjaminRuston merged 1 commit intofeature/sprint-ioda-convertersfrom Jan 12, 2023
Conversation
BenjaminRuston
approved these changes
Jan 12, 2023
Collaborator
BenjaminRuston
left a comment
BenjaminRuston
left a comment
There was a problem hiding this comment.
nice to have regression testing to show passing for that last sanity check
at this point I see no problem as both version of the code are save for posterity if needed
mer-a-o
approved these changes
Jan 12, 2023
|
|
||
| AttrData = { | ||
| 'converter': os.path.basename(__file__), | ||
| 'nvars': np.int32(len(obsvars)), |
Contributor
There was a problem hiding this comment.
Technically, this line should have been eliminated. It is deprecated.
| AttrData = { | ||
| 'converter': os.path.basename(__file__) | ||
| 'converter': os.path.basename(__file__), | ||
| 'nvars': np.int32(1), |
Contributor
There was a problem hiding this comment.
Same as last comment. This line should be eliminated, nvars is deprecated.
| varname = 'averaging_kernel_level_'+str(k+1) | ||
| vkey = (varname, 'RtrvlAncData') | ||
| self.varAttrs[vkey]['coordinates'] = 'longitude latitude' | ||
| self.varAttrs[vkey]['units'] = '' |
Contributor
There was a problem hiding this comment.
unitless and blank units should be omitted entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes those two converters actually working and be in phase with what the upgrader is doing.
We have tested various repos and skylab experiments and everything else seems good to go now.
This is the last piece to have everything in place before the merge.
Of course more changes will be done to actually go with the convention as soon as we actually can (i.e. once the IODA Fortran API merged and tested) on the ancilliary variables (averaging kernel and pressure vertices).
For the ObsVal names I think it is better to keep this out as otherwise we would need to re-upgrade all testinput/output/yaml data in ufo/ufo-data/fv3-jedi/fv3-jedi-data and r2d2 for slylab...
Thanks for your understanding on this!