Added proper PYTHONPATH setting to the airnow ctest.#1140
Merged
srherbener merged 1 commit intofeature/sprint-ioda-converters-greg3from Jan 10, 2023
Merged
Conversation
Collaborator
Author
|
@gthompsnJCSDA here is a fix for the test_iodaconv_airnow test failure. It was a missing PYTHONPATH setting (of which the other python based tests are using). |
gthompsnJCSDA
approved these changes
Jan 10, 2023
Contributor
gthompsnJCSDA
left a comment
gthompsnJCSDA
left a comment
There was a problem hiding this comment.
Perfect, thanks Steve!!
srherbener
added a commit
that referenced
this pull request
Jan 11, 2023
…via PR1100) (#1138) * manual update of develop (PR1100) into sprint branch * using develop version of export.cpp file * using develop version of DataProvider.h * switch launch to releaseTime * fix GNSSRO, cosmic2 for naming conventions and validate program * fix test ref file to contain releaseTime * get ADPUPA to pass validate program * update naming conventions as well as develop branch changes to gsi_ncdiag * fix LaunchTime name from GSI side * update/modernize AIRNow converter especially for naming conventions * fix units on amsr2_icec * remove unnecessary file (prepbufr_group_by) * update simple_groupby to naming conventions * take out aod_viirs_obs file, obsolete * update bufr_empty_fields for naming conventions * elim extra quality/precision/convergence vars from mls_o3 * removing extraneous vars from omi ozone to pass validation * removing extraneous vars from ompsnm ozone to pass validation * get pace radiance to pass ioda-validate * get pace oc-l2 to pass ioda-validate * get modis-aqua l2 to pass ioda-validate * take out extras from ostia * big re-do of tropomi CO and NO2 using 2D variables * fixing minor items for getting ci-tests working * fix tropomi for coding norms * including env python3 on top of couple scripts * update filter_split to naming conventions * update bufr_hrs to naming conventions * update bufr_mhs to naming conventions * Added proper PYTHONPATH setting to the airnow ctest. (#1140) * some fixes for naming conventions, but not yet working for gsi_ncdiag.py Co-authored-by: gthompsnJCSDA <gthompsn@ucar.edu> Co-authored-by: Stephen Herbener <stephen.herbener@gmail.com> Co-authored-by: Stephen Herbener <32968781+srherbener@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue with airnow test where the python ioda_obs_space package is not found. The fix is to add a PYTHONPATH setting to the test setup.
Issue(s) addressed
None
Acceptance Criteria (Definition of Done)
airnow test passes
Dependencies
None
Impact
None