Merged
Conversation
BenjaminRuston
added
the
needs review
CoryMartin-NOAA
approved these changes
Sep 29, 2022
Contributor
Author
|
@CoryMartin-NOAA, @nicholasesposito Please delay approving/merging this branch. I think I made a mistake.
should be
I think. I will double check when Orion is back. |
Contributor
|
@ADCollard yeah probably... see I told you don't trust my approval! |
ADCollard
removed
the
needs review
Remove reciprocal and consolidate. Taking the reciprocal of the error_variance previously was not correct.
CoryMartin-NOAA
approved these changes
Sep 30, 2022
Fix trailing whitespace
ADCollard
added
the
needs review
BenjaminRuston
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The input observation error produced by gsi_ncdiag.py is actually the output observation error from the GSI for radiances. This will populate
ObsError/brightness_temperaturewith the correct values.Issue(s) addressed
Fixes #1067
Acceptance Criteria (Definition of Done)
Correct values output to
ObsError/brightness_temperature(should contain the same values for each obs location for a given channel with no missing values).Dependencies
None
Impact
No impact on other repositories