Skip to content

bugfix witk ak and bk for multiple file concatenation#1035

Closed
jeromebarre wants to merge 3 commits intodevelopfrom
bugfix/tropomi_akbk
Closed

bugfix witk ak and bk for multiple file concatenation#1035
jeromebarre wants to merge 3 commits intodevelopfrom
bugfix/tropomi_akbk

Conversation

@jeromebarre
Copy link
Copy Markdown

Bug fix when files are concatenated the line changes allow for code not to crash because of index issue.

This was not caught by test that uses only one files as input.

I'll put a note to update testinput with multiple files in the future (too much on my plate right now)...

@jeromebarre jeromebarre added the ready for merge PR is reviewed and is ready for merge label Sep 20, 2022
@BenjaminRuston
Copy link
Copy Markdown
Collaborator

@jeromebarre do you know why this is failing, should we try an empty commit?

But's it's saying that for intel with the new containers:

The following tests FAILED:
566 - test_iodaconv_tropomi_no2_tropo (Failed)
569 - test_iodaconv_aeronet_aod (Failed)

@climbfuji
Copy link
Copy Markdown
Contributor

@jeromebarre do you know why this is failing, should we try an empty commit?

But's it's saying that for intel with the new containers:

The following tests FAILED: 566 - test_iodaconv_tropomi_no2_tropo (Failed) 569 - test_iodaconv_aeronet_aod (Failed)

These two tests started to fail with the new Intel container if I am not mistaken.

@BenjaminRuston
Copy link
Copy Markdown
Collaborator

this has already been merged with #1037

@BenjaminRuston BenjaminRuston deleted the bugfix/tropomi_akbk branch September 21, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge PR is reviewed and is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants