bugfix witk ak and bk for multiple file concatenation#1035
Closed
jeromebarre wants to merge 3 commits intodevelopfrom
Closed
bugfix witk ak and bk for multiple file concatenation#1035jeromebarre wants to merge 3 commits intodevelopfrom
jeromebarre wants to merge 3 commits intodevelopfrom
Conversation
CoryMartin-NOAA
approved these changes
Sep 1, 2022
BenjaminRuston
approved these changes
Sep 20, 2022
Collaborator
|
@jeromebarre do you know why this is failing, should we try an empty commit? But's it's saying that for intel with the new containers: The following tests FAILED: |
Contributor
These two tests started to fail with the new Intel container if I am not mistaken. |
Collaborator
|
this has already been merged with #1037 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix when files are concatenated the line changes allow for code not to crash because of index issue.
This was not caught by test that uses only one files as input.
I'll put a note to update testinput with multiple files in the future (too much on my plate right now)...