Skip to content

Updates for FMS 2022.01 and a GFDL_amos_cubed_sphere branch#65

Merged
shlyaeva merged 3 commits intodevelopfrom
feature/no_gfdl_forks
Mar 17, 2023
Merged

Updates for FMS 2022.01 and a GFDL_amos_cubed_sphere branch#65
shlyaeva merged 3 commits intodevelopfrom
feature/no_gfdl_forks

Conversation

@shlyaeva
Copy link
Contributor

@shlyaeva shlyaeva commented Mar 15, 2023

@shlyaeva shlyaeva changed the title Feature/no gfdl forks Updates for FMS 2022.01 and a GFDL_amos_cubed_sphere branch Mar 15, 2023
@shlyaeva shlyaeva added the coordinate merge Ready for merge but needs to be coordinated with other repos label Mar 15, 2023
Copy link
Collaborator

@danholdaway danholdaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work whoever did this ;)

@shlyaeva
Copy link
Contributor Author

I am going to merge this PR now: @svahl991 ran tests showing that using develop on all branches and fv3-jedi-data on this branch doesn't break the tests, and we also ran CI confirming that (https://github.com/JCSDA-internal/fv3-jedi/pull/815).
Merging this now would allow us to put this in before the data freeze date (today), and potentially have JEDI w/ FMS2022.04 functionality in v4 release.
The other corresponding PRs (fv3-bundle, fv3-jedi, fv3-jedi-linearmodel and TBD jedi-bundle and possibly mom6/soca) would have to be merged in a coordinated merge when everything is ready and approved. Code freeze is later than data freeze, so we still have time for that.

Copy link
Collaborator

@fmahebert fmahebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An early merge of this PR sounds good to me with tests that have been performed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinate merge Ready for merge but needs to be coordinated with other repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants