rollback changes in VIIRS bias correction file#56
Merged
Conversation
fabiolrdiniz
approved these changes
Jan 26, 2023
Contributor
fabiolrdiniz
left a comment
There was a problem hiding this comment.
Thanks, @shlyaeva! The unit test that uses this file passed for me on AWS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fv3jedi_test_tier2_hyb-3dvar_gfs_aero_bump_bcis failing on develop with the following error:This missing entry was likely a result of me carelessly applying the ioda-upgrader-v2-v3 to this file (the upgrader didn't need to be applied to bias files).
This PR rolls back this file to its original version, and with updated test reference
fv3jedi_test_tier2_hyb-3dvar_gfs_aero_bump_bctest pass with GNU and Intel compilers on orion.