Skip to content

rollback changes in VIIRS bias correction file#56

Merged
shlyaeva merged 1 commit intodevelopfrom
bugfix/fv3jedi-tier2
Jan 26, 2023
Merged

rollback changes in VIIRS bias correction file#56
shlyaeva merged 1 commit intodevelopfrom
bugfix/fv3jedi-tier2

Conversation

@shlyaeva
Copy link
Contributor

Description

fv3jedi_test_tier2_hyb-3dvar_gfs_aero_bump_bc is failing on develop with the following error:

162 - fv3jedi_test_tier2_hyb-3dvar_gfs_aero_bump_bc (Failed)
=> 162: Exception: oops::Variational<FV3JEDI, UFO and IODA observations> terminating...
162: Exception: Reason: An exception occurred inside ioda while opening a variable.
162: name: bias_coefficients
162: source_column: 0
162: source_filename: /home/ubuntu/code/bundle/ioda/src/engines/ioda/src/ioda/Has_Variables.cpp
162: source_function: virtual ioda::Variable ioda::detail::Has_Variables_Base::open(const string&) const
162: source_line: 108

This missing entry was likely a result of me carelessly applying the ioda-upgrader-v2-v3 to this file (the upgrader didn't need to be applied to bias files).

This PR rolls back this file to its original version, and with updated test reference fv3jedi_test_tier2_hyb-3dvar_gfs_aero_bump_bc test pass with GNU and Intel compilers on orion.

Copy link
Contributor

@fabiolrdiniz fabiolrdiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shlyaeva! The unit test that uses this file passed for me on AWS.

@shlyaeva shlyaeva merged commit 9bc2c9e into develop Jan 26, 2023
@shlyaeva shlyaeva deleted the bugfix/fv3jedi-tier2 branch January 26, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants