Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line breaks in embedded JSZip #5

Closed
JC3 opened this issue Apr 2, 2022 · 1 comment
Closed

Line breaks in embedded JSZip #5

JC3 opened this issue Apr 2, 2022 · 1 comment
Assignees
@JC3
Labels
enhancement New feature or request good first issue Good for newcomers minor

Comments

@JC3
Copy link
Owner

JC3 commented Apr 2, 2022

Try to stick some strategic linebreaks in the embedded minified JSZip.

That long line is super annoying in editors and in the GitHub web interface.
@JC3 JC3 added enhancement New feature or request good first issue Good for newcomers minor labels Apr 2, 2022
@JC3 JC3 self-assigned this Apr 4, 2022
@JC3
Copy link
Owner Author

JC3 commented Apr 4, 2022

It's pretty big. For now just split it into 4x ~25k lines and see if it helps.

@JC3 JC3 closed this as completed Apr 4, 2022
JC3 added a commit that referenced this issue Apr 4, 2022
@JC3
split long jszip line
f8cd869 
- #5: it's pretty big; for now just 4x ~25k lines and see if it helps.
JC3 added a commit that referenced this issue Apr 4, 2022
@JC3
0.9.2 feature set (#14)
18260f0 
0.9.2 feature set:

- [new] update check; quick and painless. displays a button up top if update available (#4)
- [fix] fixed tables not clearing on new file load (#12)
- [fix] displayed filename not in sync with open document (#11)
- [fix] reselecting the same file will now reload it (#13)
- [fix] corrected font size in zip compression level dropdown
- [improve] version and year bump
- [improve] update screenshot although... it's pretty much the same (#7)
- [code] simplified and cleaned up path stripping code (#1, #8, #10)
- [code] slightly more proper html
- [code] split up long jszip line (#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JC3 JC3

Labels
enhancement New feature or request good first issue Good for newcomers minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JC3