update #6
Merged
update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a string to describe hotkeys for menu items in the Windows back-end. Part of work tracked in #1306
I'm going to do another piet pre-release shortly, and would like to avoid breakage.
This implements the new save/open (#1068) API on macOS. The implementation here is slightly different; Cocoa uses the idea of 'blocks' (a c extension for callbacks) in most of their async API, so we don't need to to manually defer the work.
This also adds back a method that was removed from Region, with a deprecation notice.
Display hotkeys for menu items in Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.