Fix case sensitive lookups in re3data software dict #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Great little tool that could help us out a lot with automating the download process from certain data portals! Thanks for making this available to the research community!
I wanted to try it out, but bumped into a small issue, which I hope this PR fixes. When trying out a download from a Dataverse repository that is not in the fast lookup table
SERVICES_NETLOC
, the API resorted to theRE3DATA_SOFTWARE
lookup table, where I got the following KeyError:The dataset in question can be found here: https://ssh.datastations.nl/dataset.xhtml?persistentId=doi:10.17026/dans-279-hy72
'DataVerse' is however in the
RE3DATA_SOFTWARE
lookup table, but with a different case. I created this pull request to make the keys inRE3DATA_SOFTWARE
case-insensitive.Cheers,
Ahmad