fix: handle AGY auth-required quota state - #10
Merged
Merged
Conversation
added 15 commits
September 20, 2026 02:31
Ivory2024
added a commit
that referenced
this pull request
Sep 28, 2026
… passes (#66) `bin/fm-doc-audience-check.sh` requires every tracked `*.md`/`*.txt` to carry an audience classification in `docs/documentation-audiences.json`. `.omo/` had no `.gitignore` rule, so OMO evidence leaked into git starting at `4d9585fb` (PR #10) and every later batch landed unclassified. The symptom is a red required check on `main`, which fails every open PR with it: `Behavior portable serial 7` fails at `tests/fm-documentation-audiences.test.sh` with `not ok - repository documentation audience check failed`. This branch and `origin/main` both reproduce it identically. Three changes: - `.gitignore` gains `.omo/`. - `git rm -r --cached .omo` untracks 37 files. Every one stays on disk; this changes tracking, not content. - The 9 `.omo` entries in the audience manifest are removed (115 -> 106 surfaces, a pure 36-line deletion with no reformatting). Those 9 were classified `maintainer-verification`, which `.agents/skills/firstmate-coding-guidelines/SKILL.md` reserves for active reusable empirical facts. They are not that. Eight title themselves `Gate review: base 1bb72cc to target 466e0d6` and carry `recommendation: REJECT`, `originalIntent` and `userOutcomeReview`; the ninth is `Manual QA matrix: base 1bb72cc -> target 466e0d6`. All nine are one branch's review output, so the decision tree places them at tier 6, task and incident evidence, which belongs in a private task report rather than a maintained surface. Verification: `tests/fm-documentation-audiences.test.sh` passes where `origin/main` fails; `tests/fm-test-run.test.sh` passes; `git diff --check` is clean; `git ls-files .omo` returns 0. Independently reviewed over a bidirectional session before this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
When AGY quota data is
auth_required, keep the candidate eligible but unranked and surface the exact authentication cause without fabricating quota values or authorizing AGY dispatch.Changes
Verification
01M2XXRVQAA4W7P5WSJK2D8Z50: review completed; test completed with an explicit documented exception; document and lint passed.bash tests/fm-dispatch-resolve.test.shpassed.quota-axi --jsonconfirmedAGY=auth_requiredwithAntigravity sign-in required.TYPESAFE_API_KEYis absent; rerun that scenario when the credential is available. This is recorded as a test exception, not green evidence.This PR targets
Ivory2024/firstmateonly. No commits were pushed tokunchenguid/firstmate.Pipeline
Updates from git push no-mistakes