Skip to content

Fix: Prevent infinite loop when serializing assets with reflection types #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix: Prevent infinite loop when serializing assets with reflection types #296

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8ab394
Fix: Handle null component in AddComponent when already exists or can…
kreys Oct 27, 2025
726b331
Fix infinite loop in asset serialization with reflection types
Oct 27, 2025
9a76e7f
Addressed pull request feedback
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Unity-MCP-Plugin/Assets/root/Editor/Scripts/API/Tool/GameObject.AddComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ GameObjectRef gameObjectRef

var newComponent = go.AddComponent(type);

if (newComponent == null)
{
stringBuilder.AppendLine($"[Warning] Component '{componentName}' already exists on GameObject or cannot be added.");
continue;
}

stringBuilder.AppendLine($"[Success] Added component '{componentName}'. Component instanceID='{newComponent.GetInstanceID()}'.");
}

Expand Down
26 changes: 25 additions & 1 deletion ...MCP-Plugin/Assets/root/Runtime/ReflectionConverters/Base/UnityArrayReflectionConvertor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,30 @@ public partial class UnityArrayReflectionConvertor : ArrayReflectionConvertor
public override IEnumerable<FieldInfo>? GetSerializableFields(Reflector reflector, Type objType, BindingFlags flags, ILogger? logger = null)
=> objType.GetFields(flags)
.Where(field => field.GetCustomAttribute<ObsoleteAttribute>() == null)
.Where(field => field.IsPublic || field.IsPrivate && field.GetCustomAttribute<SerializeField>() != null);
.Where(field => field.IsPublic || field.IsPrivate && field.GetCustomAttribute<SerializeField>() != null)
.Where(field => !IsReflectionType(field.FieldType));

public override IEnumerable<PropertyInfo>? GetSerializableProperties(Reflector reflector, Type objType, BindingFlags flags, ILogger? logger = null)
{
var baseProperties = base.GetSerializableProperties(reflector, objType, flags, logger);
if (baseProperties == null) return null;

return baseProperties.Where(prop => !IsReflectionType(prop.PropertyType));
}

private static bool IsReflectionType(Type type)
{
// Prevent serialization of reflection types that cause circular references
if (type == null) return false;

var fullName = type.FullName;
if (string.IsNullOrEmpty(fullName)) return false;

return fullName.StartsWith("System.Reflection.") ||
fullName == "System.RuntimeType" ||
fullName == "System.Reflection.RuntimeModule" ||
fullName == "System.Reflection.RuntimeAssembly" ||
fullName == "System.Type";
}
}
}
27 changes: 26 additions & 1 deletion ...P-Plugin/Assets/root/Runtime/ReflectionConverters/Base/UnityGenericReflectionConvertor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,31 @@ public partial class UnityGenericReflectionConvertor<T> : GenericReflectionConve
public override IEnumerable<FieldInfo>? GetSerializableFields(Reflector reflector, Type objType, BindingFlags flags, ILogger? logger = null)
=> objType.GetFields(flags)
.Where(field => field.GetCustomAttribute<ObsoleteAttribute>() == null)
.Where(field => field.IsPublic || field.IsPrivate && field.GetCustomAttribute<SerializeField>() != null);
.Where(field => field.IsPublic || field.IsPrivate && field.GetCustomAttribute<SerializeField>() != null)
.Where(field => !IsReflectionType(field.FieldType));

public override IEnumerable<PropertyInfo>? GetSerializableProperties(Reflector reflector, Type objType, BindingFlags flags, ILogger? logger = null)
{
var baseProperties = base.GetSerializableProperties(reflector, objType, flags, logger);
if (baseProperties == null) return null;

return baseProperties.Where(prop => !IsReflectionType(prop.PropertyType));
}

private static bool IsReflectionType(Type type)
{
// Prevent serialization of reflection types that cause circular references
// RuntimeType -> RuntimeModule -> RuntimeAssembly -> RuntimeModule -> ...
if (type == null) return false;

var fullName = type.FullName;
if (string.IsNullOrEmpty(fullName)) return false;

return fullName.StartsWith("System.Reflection.") ||
fullName == "System.RuntimeType" ||
fullName == "System.Reflection.RuntimeModule" ||
fullName == "System.Reflection.RuntimeAssembly" ||
fullName == "System.Type";
}
}
}