-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to AndroidX. #54
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,22 @@ | ||
language: android | ||
android: | ||
components: | ||
- platform-tools | ||
- tools | ||
- build-tools-27.0.3 | ||
- android-27 | ||
- extra-android-support | ||
- extra-android-m2repository | ||
|
||
jdk: oraclejdk8 | ||
jdk: | ||
- oraclejdk8 | ||
|
||
before_script: | ||
- chmod +x gradlew | ||
before_install: | ||
# Install SDK license so Android Gradle plugin can install deps. | ||
- mkdir "$ANDROID_HOME/licenses" || true | ||
- echo "d56f5187479451eabf01fb78af6dfcb131a6481e" > "$ANDROID_HOME/licenses/android-sdk-license" | ||
|
||
script: | ||
./gradlew build | ||
install: true | ||
|
||
script: ./gradlew clean build | ||
|
||
before_cache: | ||
- rm -f $HOME/.gradle/caches/modules-2/modules-2.lock | ||
- rm -fr $HOME/.gradle/caches/*/plugin-resolution/ | ||
cache: | ||
directories: | ||
- $HOME/.gradle/caches/ | ||
- $HOME/.gradle/wrapper/ | ||
- $HOME/.android/build-cache |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ apply plugin: 'com.android.application' | |
|
||
android { | ||
compileSdkVersion COMPILE_SDK_VERSION | ||
buildToolsVersion BUILD_TOOLS_VERSION | ||
|
||
defaultConfig { | ||
applicationId "com.github.ivbaranov.rxbluetooth.example" | ||
|
@@ -24,6 +23,5 @@ android { | |
|
||
dependencies { | ||
implementation project(':rxbluetooth') | ||
implementation "com.android.support:appcompat-v7:$SUPPORT_LIBRARY_VERSION" | ||
implementation "com.android.support:design:$SUPPORT_LIBRARY_VERSION" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need |
||
} | ||
implementation "androidx.appcompat:appcompat:$ANDROIDX_APPCOMPAT_VERSION" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,36 @@ | ||
# suppress inspection "UnusedProperty" for whole file | ||
|
||
# Compile SDK version (SDK platform to compile with) | ||
COMPILE_SDK_VERSION=android-27 | ||
|
||
# Build tools version (Build tools version to build with) | ||
BUILD_TOOLS_VERSION=27.0.3 | ||
COMPILE_SDK_VERSION=android-28 | ||
|
||
# Minimum SDK version (lowest SDK platform to target) | ||
MIN_SDK_VERSION=11 | ||
MIN_SDK_VERSION=14 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Required by AndroidX There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you think min SDK version 11 deserves its own branch or it will be ok to leave it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nah. AndroidX requires 14. And everyone else does too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still feel bad about moving up min SDK version of library. If that should be a major version change so 2.x.x branch to be left for 11+ and 3.x.x for 14+ and androidx? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No one is using minSdk < 14 and if so they can use the old version since they won't be using AndroidX anyways. |
||
|
||
# Target SDK version (highest SDK platform to target) | ||
TARGET_SDK_VERSION=26 | ||
TARGET_SDK_VERSION=28 | ||
|
||
# Current library version | ||
VERSION_NAME=2.0.4 | ||
VERSION_CODE=19 | ||
|
||
# Dependency versions (library) | ||
SUPPORT_LIBRARY_VERSION=25.3.1 | ||
RXANDROID_VERSION=2.0.2 | ||
RXJAVA_VERSION=2.1.12 | ||
RXANDROID_VERSION=2.1.0 | ||
RXJAVA_VERSION=2.2.5 | ||
ANDROIDX_ANNOTATION_VERSION=1.0.1 | ||
ANDROIDX_APPCOMPAT_VERSION=1.0.0 | ||
|
||
# Dependency versions (plugins) | ||
GRADLE_PLUGIN_VERSION=3.1.2 | ||
GRADLE_PLUGIN_VERSION=3.2.1 | ||
BINTRAY_RELEASE=0.8.1 | ||
|
||
# Maven | ||
USER_ORG=ivbaranov | ||
GROUP=com.github.ivbaranov | ||
ARTIFACT_ID=rxbluetooth2 | ||
|
||
android.useAndroidX=true | ||
android.enableJetifier=false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We're AndroidX only. ❤️ |
||
|
||
POM_DESCRIPTION=Android reactive bluetooth | ||
POM_URL=https://github.com/ivbaranov/RxBluetooth | ||
POM_SCM_URL=https://github.com/ivbaranov/RxBluetooth | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
#Thu May 10 13:07:46 MSK 2018 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Android Gradle Plugin handles this by default now