Taxes #62
Taxes #62
Conversation
Applied taxes on profits
Now /checkprofit can be used on other people if you have the permission "ecs.checkprofits.other". The player target has to be included at the end of the command. Example: "/cp p 1 Player".
| } | ||
| } | ||
|
|
||
| deposit(price, deposit); |
There was a problem hiding this comment.
This line generates a bug that gives player 2 times deposit instead of one. Could even call it a malicious code...
The deposit(taxes ,Bukkit.getOfflinePlayer(Config.leader)); section doesn't return when deposit is done, and then goes to the next deposit function and do it again.
There was a problem hiding this comment.
Also comments on sections are appreciated, you must explain in simple terms what you are doing line by line
There was a problem hiding this comment.
Your correction has no sense because the first deposit is for the "State": it deposits the taxes to the leader who represents the state. The second deposit is for the seller. I would like to ask you to test it first and then write that there is a "malicious code" or a "bug". Indeed me and Elito have already tested it 3 months ago (.......) and it works.
There was a problem hiding this comment.
I don't understand this section much since Elito coded it, needs @ElitoGame 's review.
| //if the command is executed on another player | ||
| Player target = null; | ||
| int isOther = 0; | ||
| if(p.hasPermission("ecs.checkprofits.other")){ |
There was a problem hiding this comment.
What if player doesn't have the permission and target stays null?
| taxes: | ||
| sell-to-shop-tax-percent: 0 | ||
| buy-from-shop-tax-percent: 0 | ||
| collecting-player-name: "" |
There was a problem hiding this comment.
tax officer name would better? Not sure if we have to even include this since it's just taxes and everyone knows the server is collecting the tax.
Added taxation