-
Notifications
You must be signed in to change notification settings - Fork 40
[MOB-12267] add pauseEmbeddedImpression method to manage embedded message impressions #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lposen
wants to merge
9
commits into
loren/embedded/MOB-12264-android-sync-and-get-messages
Choose a base branch
from
loren/embedded/MOB-12267-android-add-start-impression-and-pause-impressio
base: loren/embedded/MOB-12264-android-sync-and-get-messages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b1e5760
feat: add startEmbeddedImpression method to manage embedded message i…
lposen ed9b4ad
feat: add pauseEmbeddedImpression method to manage embedded message i…
lposen ebe8c47
Merge branch 'loren/embedded/MOB-12265-start-end-session' into loren/…
lposen c942457
feat: add logging for start and pause embedded impression methods in …
lposen da20dcf
test: add unit tests for sync and impression methods in IterableEmbed…
lposen a626f06
Merge branch 'loren/embedded/MOB-12264-android-sync-and-get-messages'…
lposen 9e07bac
Merge branch 'loren/embedded/MOB-12264-android-sync-and-get-messages'…
lposen 49f5e2f
docs: add internal usage note to setEnabled method in IterableEmbedde…
lposen 718a158
docs: clarify internal usage note for setEnabled method in IterableEm…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -48,6 +48,26 @@ export const Embedded = () => { | |||||||
| }); | ||||||||
| }, [getPlacementIds]); | ||||||||
|
|
||||||||
| const startEmbeddedImpression = useCallback( | ||||||||
| (message: IterableEmbeddedMessage) => { | ||||||||
| console.log(`startEmbeddedImpression`, message); | ||||||||
| Iterable.embeddedManager.startImpression( | ||||||||
| message.metadata.messageId, | ||||||||
| // TODO: check if this should be changed to a number, as per the type | ||||||||
| Number(message.metadata.placementId) | ||||||||
|
Comment on lines
+57
to
+58
|
||||||||
| // TODO: check if this should be changed to a number, as per the type | |
| Number(message.metadata.placementId) | |
| message.metadata.placementId |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.