Skip to content

Conversation

@Ayyanchira
Copy link
Member

@Ayyanchira Ayyanchira commented May 2, 2023

[MOB-4666] in apps config memory

🔹 Jira Ticket(s) if any

✏️ Description

Cherry picks #474 onto master branch

“Akshay added 2 commits May 2, 2023 10:54
Attempt to fix this error

* What went wrong:
Execution failed for task ':app:processDebugAndroidTestManifest'.
> Could not resolve all files for configuration ':app:debugAndroidTestRuntimeClasspath'.
   > Could not download kappuccino-1.2.1.aar (br.com.concretesolutions:kappuccino:1.2.1)
      > Could not get resource 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'.
         > Could not GET 'https://jcenter.bintray.com/br/com/concretesolutions/kappuccino/1.2.1/kappuccino-1.2.1.aar'.
            > Connection reset
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 31.25% and project coverage change: -0.20 ⚠️

Comparison is base (0ccbc12) 62.48% compared to head (911e790) 62.29%.

❗ Current head 911e790 differs from pull request most recent head dc124e0. Consider uploading reports for the commit dc124e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   62.48%   62.29%   -0.20%     
==========================================
  Files          67       67              
  Lines        3956     3970      +14     
  Branches      461      462       +1     
==========================================
+ Hits         2472     2473       +1     
- Misses       1239     1253      +14     
+ Partials      245      244       -1     
Impacted Files Coverage Δ
...com/iterable/iterableapi/IterableInAppManager.java 83.63% <18.18%> (-3.04%) ⬇️
.../java/com/iterable/iterableapi/IterableConfig.java 74.46% <50.00%> (-2.28%) ⬇️
...ain/java/com/iterable/iterableapi/IterableApi.java 61.89% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ayyanchira Ayyanchira changed the title Merge pull request #474 from Iterable/jay/MOB-4666-in-apps-config-memory [MOB - 6164] Merge pull request #474 from Iterable/jay/MOB-4666-in-apps-config-memory May 2, 2023
@Ayyanchira Ayyanchira requested review from evantk91 and roninopf May 2, 2023 18:42
repositories {
mavenCentral()
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been added to fix small CI issue that was popping up on master branch. So now the master branch CI is working normally

@Ayyanchira
Copy link
Member Author

Apart from build.gradle changes, all other changes have been already approved previously on #474

@Ayyanchira Ayyanchira merged commit 650679e into master May 2, 2023
@Ayyanchira Ayyanchira deleted the CherryPick-InMemoryStorage-on-Master branch May 2, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants