Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple cameras with same vendor/product id aren't disambiguated #59

Closed
jazzychad opened this issue May 4, 2022 · 1 comment
Closed

Multiple cameras with same vendor/product id aren't disambiguated #59

jazzychad opened this issue May 4, 2022 · 1 comment
Assignees
@Itaybre
Labels
bug Something isn't working
Milestone
1.4.0

Comments

@jazzychad
Copy link
Contributor

Describe the bug
If you have two or more cameras with the same product and vendor id plugged into the USB host/bus, changing the slider values after choosing a camera may instead change the value for the other camera with the same vendor/product id.

To Reproduce
Steps to reproduce the behavior:

  1. Plug in multiple cameras with the same USB product and vendor ids2.
  2. See them in the dropdown picker of the app
  3. Select one
  4. Change a slider value in the basic settings
  5. You might see an update in the preview window, this means that the value is changed for the currently selected camera6.
  6. Select the other camera from the drop down
  7. Change the same setting. You might not see any change in the preview window, but if you look back at the other camera, you will see that it has changed instead

Expected behavior
Changing the slider values for a selected camera should update the values for that camera (and not another one)

Desktop (please complete the following information):

  • Version 1.3.1
  • Camera: n/a .. just as long as multiple have the same product/vendor id

Additional context
the usbDevice() extension method on AVCaptureDevice doesn't use enough information to disambiguate the interfaceRef returned by the dictionary passed into IOServiceGetMatchingService (in AVCaptureDevice+USB.swift), so the usb interface that is returned for each different AVCaptureDevice is actually pointing at the same end device (which causes settings changes in the UI to be routed to the same end camera).

I am actively looking into a solution for this issue by using more keys in the lookup dictionary for IOServiceGetMatchingService
@jazzychad jazzychad added the bug Something isn't working label May 4, 2022
jazzychad added a commit to jazzychad/CameraController that referenced this issue May 4, 2022
@jazzychad
Disambiguate cameras with same product/vendor ids (issue Itaybre#59)
ed2d0fc 
Fix issue where `AVCaptureDevice.usbDevice()` would return a USBDevice
pointing to the wrong camera if multiple cameras with the same product
id and vendor id are attached to the computer.

The new approach is to use an iterator to lookup the cameras with the
given vendor and product ids, and then loop through the results and
match against their property dictionaries against the
avDevice.localizedName since that seems to be the only reliable way to
disambiguate between different cameras with otherwise similar
properties.
jazzychad added a commit to jazzychad/CameraController that referenced this issue May 4, 2022
@jazzychad
Disambiguate cameras with same product/vendor ids (issue Itaybre#59)
55729c6 
Fix issue where `AVCaptureDevice.usbDevice()` would return a USBDevice
pointing to the wrong camera if multiple cameras with the same product
id and vendor id are attached to the computer.

The new approach is to use an iterator to lookup the cameras with the
given vendor and product ids, and then loop through the results and
match against their property dictionaries against the
avDevice.localizedName since that seems to be the only reliable way to
disambiguate between different cameras with otherwise similar
properties.
@jazzychad
Copy link
Contributor Author

I have opened a PR for this issue: #60

Itaybre added a commit that referenced this issue May 5, 2022
@Itaybre
Merge pull request #60 from jazzychad/jc-disambiguate-cameras
73d2c1c 
Disambiguate cameras with same product/vendor ids (issue #59)
@Itaybre Itaybre closed this as completed May 5, 2022
@Itaybre Itaybre added this to the 1.4.0 milestone May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Itaybre Itaybre

Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@jazzychad @Itaybre