handle teams v2 meeting invites differently than v1 invites. making the default logger electron-log, as the config options seeem to be broken #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
IsmaelMartinez
commented
Aug 23, 2024
IsmaelMartinez
commented
- handle teams v2 meeting invites differently than v1 invites. This might fix Teams Link not opening #1373 and The meeting invitation are not working as expected #1370
- making the default logger electron-log, as the config options seem to be broken
…he default logger electron-log, as the config options seeem to be broken
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -199,19 +199,25 @@ | |||
| } | |||
|
|
|||
| function processArgs(args) { | |||
| const regMS = /^msteams:\/.*(?:meetup-join|channel)/g; | |||
| const v1msTeams = /^msteams:\/l\/(?:meetup-join|channel)/g; | |||
| const v2msTeams = /^msteams:\/\/teams.microsoft.com\/l\/(?:meetup-join|channel)/g; | |||
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High
IsmaelMartinez
deleted the
feature-1373-handle-teams-v2-msteams-invites
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.