Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to upstream react changes for idle tracking #1243

Merged

Conversation

bastidest
Copy link
Contributor

It seems like the Teams developers changed some of the internal structure of how to access the core services components. This commit makes accessing the core services more robust by trying out different attribute paths.

Possibly related to #1198

It seems like the Teams developers changed some of the internal
structure of how to access the core services components.  This commit
makes accessing the core services more robust by trying out different
attribute paths.
@petterhs
Copy link

petterhs commented May 2, 2024

I'm having the same issue as in #577 (comment) and your fix works for me!

@jijojosephk
Copy link
Collaborator

@bastidest this is awesome! could you update the package.json and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details?

@bastidest
Copy link
Contributor Author

Done

@IsmaelMartinez IsmaelMartinez merged commit 72922c7 into IsmaelMartinez:develop May 3, 2024
4 checks passed
@IsmaelMartinez
Copy link
Owner

Thanks a lot for contributing! I just merge it and it should hopefully be released soon. Thanks a lot!

@storm9c1
Copy link

storm9c1 commented May 3, 2024

Does this mean that --appIdleTimeout now works properly again?

If so, thank you, thank you, thank you! I work on multiple virtual desktops. And having it time out was causing me to miss notifications... Seems like after Teams idles for between 5-10 minutes, it would mark me idle even if I was working in other desktops. And then eventually after another period of time, it would show me as offline. Same was happening for a colleague. Once that happens, I stop getting notifications. And that caused me to miss chats and meetings. I'm hoping that by tweaking --appIdleTimeout to some high value, as I did for v1, I can prevent this.

EDIT: missed the tie to #1198 -- will try 1.4.35 and see if the situation is better. Thanks!

@IsmaelMartinez
Copy link
Owner

Hopefully it does work also for you and you can start using the work legend to describe @bastidest 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants