Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build universal Mac app, it is broken on Apple Silicon #1228

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:

- name: Release
if: contains(github.ref, 'develop')
run: yarn dist:mac -- --publish always
run: yarn dist:mac:x64 -- --publish always

exe:
runs-on: windows-latest
Expand Down
21 changes: 21 additions & 0 deletions KNOWN_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,24 @@ If the above doesn't work:
Refer to [#171](https://github.com/IsmaelMartinez/teams-for-linux/issues/171) for more info

If when you reload or close the application you get the blank page again, please repeat the second workaround.

## No Apple Silicon Mac build
It appears that Apple Silicon can't run unsigned code, and the Apple Developer account that is required for signing
costs $99/year. Thus, only Intel Mac release is pre-built in Github releases. This issue is tracked in
[#1225](https://github.com/IsmaelMartinez/teams-for-linux/issues/1225).

The Intel build works on Apple Silicon Macs, but runs slow because it is emulated.

You can **build your own Apple Silicon build from this repo yourself**, signed with your own local developer account keys. This is free, but the keys work only on our Mac.

The steps below expect that you have NodeJS and Yarn installed (both are in Homebrew).

1. Download XCode (from AppStore)
2. Open it
3. Menu bar XCode -> Settings -> Accounts
4. Select your account -> Manage certificates
5. Click plus on lower left -> Apple development
6. Close the settings menu and create a new project in XCode. Does not matter which one, just create something using
the wizard, doesn't matter what. This is required to get the certificate into your local Keychain as trusted.
7. Run `yarn install`, `yarn dist:mac:arm64` in this repository. You should see `signing` step in the output with no errors, except for `skipped macOS notarization` warning.
8. The app is built in the `dist/mac-arm64/` folder, from where you can copy it to Applications.
12 changes: 11 additions & 1 deletion com.github.IsmaelMartinez.teams_for_linux.appdata.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,16 @@
<url type="bugtracker">https://github.com/IsmaelMartinez/teams-for-linux/issues</url>
<launchable type="desktop-id">com.github.IsmaelMartinez.teams_for_linux.desktop</launchable>
<releases>
<release version="1.4.32" date="2024-04-28">
<description>
<ul>
<li>
Revert "Build universal app for Mac" - the unsigned package does not run on Apple Silicon.
See KNOWN_ISSUES.md for steps how to build the app for Apple Silicon locally.
</li>
</ul>
</description>
</release>
<release version="1.4.31" date="2024-04-25">
<description>
<ul>
Expand All @@ -28,7 +38,7 @@
</ul>
</description>
</release>
<release version="1.4.29" date="2024-04-22">
<release version="1.4.29" date="2024-04-22">
<description>
<ul>
<li>Build universal app for Mac, to support Apple Silicon as well as Intel Macs</li>
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "teams-for-linux",
"version": "1.4.31",
"version": "1.4.32",
"main": "app/index.js",
"description": "Unofficial client for Microsoft Teams for Linux",
"homepage": "https://github.com/IsmaelMartinez/teams-for-linux",
Expand Down Expand Up @@ -31,7 +31,8 @@
"dist:linux:appimage": "electron-builder --x64 --armv7l --arm64 -l AppImage",
"dist:linux:snap": "electron-builder -l snap",
"dist:linux:snap:armv7l": "electron-builder --armv7l -l snap",
"dist:mac": "electron-builder --mac --universal",
"dist:mac:x64": "electron-builder --mac --x64",
"dist:mac:arm64": "electron-builder --mac --arm64",
"dist:windows": "electron-builder --windows --x64",
"dist:linux:x64": "electron-builder --x64 -l tar.gz deb rpm AppImage",
"dist:linux:arm64": "electron-builder --arm64 -l tar.gz deb rpm AppImage",
Expand Down
Loading