Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message if configuration is invalid #1224

Conversation

woernsn
Copy link
Contributor

@woernsn woernsn commented Apr 26, 2024

Attempt to implement #1220

app/config/index.js Outdated Show resolved Hide resolved
@woernsn woernsn requested a review from IsmaelMartinez April 26, 2024 17:02
@IsmaelMartinez
Copy link
Owner

could you update the package.json, increasing the lower number by one, and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details? Thanks again and apologies is taking longer to merge. Busy life!

@woernsn
Copy link
Contributor Author

woernsn commented May 3, 2024

could you update the package.json, increasing the lower number by one, and com.github.IsmaelMartinez.teams_for_linux.appdata.xml with version details? Thanks again and apologies is taking longer to merge. Busy life!

Updated to 1.4.38.
So you are creating a release per commit?
Good to know for future PRs 😄.

@IsmaelMartinez IsmaelMartinez merged commit a78d508 into IsmaelMartinez:develop May 6, 2024
3 checks passed
@IsmaelMartinez
Copy link
Owner

Sometimes we do merge a few PRs together... but that is rare. Thanks for your contribution! I will release it as pre-release https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.38 for a couple of days. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants