Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface and use trait to make the config service a cacheable dependency #41

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

adam-vessey
Copy link
Contributor

... really, just inheriting cachability from the config at which it points.

GitHub Issue: Somewhat auxiliary to Islandora/documentation#2134

What does this Pull Request do?

Views dependent on the config behind the service can more easily be given the dependency on the config.

What's new?

Make the \Drupal\openseadragon\Config service implement the \Drupal\Core\Cache\CacheableDependencyInterface and return appropriately.

  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Unlikely.

How should this be tested?

Presently, has no observable outcome; however, this will allow for cached items to be appropriately invalidated when the config changes.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

…pendency...

... really, just inheriting cachability from the config at which it points.
@jordandukart
Copy link
Member

Looking a-ok to me.

@seth-shaw-asu seth-shaw-asu self-requested a review August 31, 2022 17:51
Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-asu seth-shaw-asu merged commit c55e1e6 into Islandora:2.x Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants