Add interface and use trait to make the config service a cacheable dependency #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... really, just inheriting cachability from the config at which it points.
GitHub Issue: Somewhat auxiliary to Islandora/documentation#2134
What does this Pull Request do?
Views dependent on the config behind the service can more easily be given the dependency on the config.
What's new?
Make the
\Drupal\openseadragon\Config
service implement the\Drupal\Core\Cache\CacheableDependencyInterface
and return appropriately.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
Presently, has no observable outcome; however, this will allow for cached items to be appropriately invalidated when the config changes.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers