Make path to openseadragon images protocol relative #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We encountered mixed content warnings in the browser console as OS on an HTTPS site was requesting its navigation button images via HTTP even with X-Forwarded-Proto configured. Even though it's due to be removed (https://www.drupal.org/project/drupal/issues/2669074 ) `file_url_transform_relative()` fixes the issue.
|
this might be superceded by #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#1504
What does this Pull Request do?
We encountered mixed content warnings in the browser console as OS on an HTTPS site was requesting its navigation button images via HTTP even with X-Forwarded-Proto configured. Even though it's due to be removed (https://www.drupal.org/project/drupal/issues/2669074 )
file_url_transform_relative()fixes the issue.What's new?
Wrap
file_create_url()withfile_url_transform_relative().How should this be tested?
Visit a Repository Item page on a site served by https and observe mixed content warnings in browser console. Apply patch. Reload page and observe no mixed content warnings.
Interested parties
@Islandora/8-x-committers