Not overriding set models. #207
Conversation
| @@ -560,7 +560,7 @@ function xml_form_builder_update_object(AbstractObject $object, array $associati | |||
| if ($label) { | |||
| $object->label = $label; | |||
| } | |||
| $object->models = array($association['content_model']); | |||
| $object->models = array_merge($object->models, array($association['content_model'])); | |||
There was a problem hiding this comment.
Wouldn't array_unique or the like be better to avoid duplicating content-models? Or is there a use case for having multiple of the same content-model in here?
There was a problem hiding this comment.
This is handled at a lower level.
There was a problem hiding this comment.
For clarity and posterity, where is it handled?
There was a problem hiding this comment.
Not overriding set models.
|
I think it would have been extremely helpful to have not merged until @DiegoPino provided some input here since he is the component manager. |
|
@willtp87 and @jordandukart. It's time to discuss some open issues that require the whole community attention. Most of us contribute to this community with the sole intention of making Islandora a better software. We all join each week in long discussions on what/how to fix problems detected in the stack and most of the time i see people getting their pulls and code reviewed and even sometimes rejected. This is good because it's a group decision. People act accordingly and always follow the group's suggestions and also your view on the stack because you have a deep knowledge on this. We all learn. We grow. That said, a better software it's not only build on good code, also on strong community. And community stays working for us and for you, when there is respect and common rules that apply to everyone. If you look closely, the whole reason for having this pull is because you have been doing this systematically before. Unit tests are good, but external human review is even better because interaction between modules requires real UI testing sometimes. I don't know if you are aware of this, but every time you add new code to the stack without discussing, merge without asking at least the maintainer's opinion, you are sub-estimating the community, not only a particular person. Your pull is correct in terms of code so i won't reject this merge. But the way you are acting is not right and the consequences are many, one of them is introducing bugs, this is not the first time, but the most important and dangerous one is making the community weak. |
|
👍 to @DiegoPino's comments. These type of changes make it much harder to work with the project and begs the question of how much hassle is Islandora worth. |
|
👍 to @DiegoPino and @whikloj's comments as well. This continued behavior that is antagonistic to community developers is alienating, and destructive to the project. This is an example of why I am not serving as release manager after this release. It just isn't worth the frustration anymore. |
No description provided.