added pdf/a conversion support

[axfelix]

Added an option to create PDF/A derivatives, as proposed in https://jira.duraspace.org/browse/ISLANDORA-1130?

[ruebot]

If you've added a new module dependcy, you'll need to update .travis.yml as well.

If you edit this to this:

 - drush dl imagemagick ghostscript
 - drush en --user=1 --yes imagemagick ghostscript islandora_basic_collection islandora_pdf

That should push Travis along.

[axfelix]

that was actually a complete flub on my part -- there isn't actually a new drupal module dependency, and I'd already added the note to install ghostscript to the readme; I'd just finished dealing with a couple hours of php and git rebase stuff, which is not my forte, and apparently decided to add that line to the .info for no reason. new commit should fix it.

[ruebot]

Lots of coding standards stuff to fix https://travis-ci.org/Islandora/islandora_solution_pack_pdf/jobs/42266277#L234-L260 😄

[axfelix]

I need to find the sublime text setting for "don't always break indentation
in php projects without realizing it so that you don't have to go back
later and pedantically change stuff you had no idea was wrong," since this
isn't the first time this has happened to me...

-alex

On Wed, Nov 26, 2014 at 7:22 PM, Nick Ruest [email protected]
wrote:

Lots of coding standards stuff to fix
https://travis-ci.org/Islandora/islandora_solution_pack_pdf/jobs/42266277#L234-L260 [image:
😄]

—
Reply to this email directly or view it on GitHub
#84 (comment)
.

[ruebot]

Or you could just use VIM 😏

[axfelix]

I think if I get that in response one more time I might decide to become an alpaca farmer

(I do use vim, but for god's sake, not all the time)!

[axfelix]

evidently Travis thinks that's in fact substantially worse.

[ruebot]

https://www.drupal.org/coding-standards

[axfelix]

yup, I know, I'm just determined to find a way to find a sane way to automate that as it's given me too much grief already. couple days, hopefully.

[ruebot]

Let me know if you need a hand in irc. More than willing to help out.

[axfelix]

nope, apparently using the actual Drupal-maintained tools elevates me from minor warnings to normal warnings!

[axfelix]

well, I can't say I feel good about the time spent, but it's done and it's going to pass now. shall I freebase the commits so it's less messy?

[axfelix]

I may have freebased it incorrectly

[ruebot]

Rebase? git rebase -i HEAD~8 should do it for you (assuming it is 8 commits and I counted correcty). Then do a force push.

[ruebot]

You now definitely deserve an Islandora Camp award for inspiring memes! (@manez)

[ruebot]

...that said, I'll fire this up in a clean VM tommorrow and do a smoke test. If everything is good to go, I'll merge.

[ruebot]

I can't set the path to gs, even though the path is valid.

[axfelix]

if you run Gs from the cli without any parameters, what's the exit code?

[ruebot]

$ gs
GPL Ghostscript 9.05 (2012-02-08)
Copyright (C) 2010 Artifex Software, Inc.  All rights reserved.
This software comes with NO WARRANTY: see the file PUBLIC for details.
GS>

[axfelix]

Ah, got it -- you must have a display server on that machine; the path test is supposed to automatically terminate with exit code 1 if it can't initialize a display. I'll change it so it's called differently.

[ruebot]

Nope. No display server. That is a vagrant VM.

[axfelix]

I actually have no idea if any of these rebases are doing what they're supposed to

[ruebot]

I wouldn't worry about rebasing your commits until we're ready to merge.

Also, in the future, if you're working on a JIRA ticket, you need to create a branch for that. JIRA will automatically pick up the activity here if you do that.

[axfelix]

gotcha. for my understanding, though, has the rebase actually succeeded, so far as you can tell? I still managed to fuck up and create two commits where I only wanted one, but there should at least only be two new commits on my fork at this point if I squashed the rest properly, rather than like 11... gs pathing bug is fixed, too.

[ruebot]

It really depends on what your rebase goal is. If you're trying to squash all of this down to a single commit, then no.

[axfelix]

right then. I need to walk away from this again for now, so I'll figure out what's going wrong eventually.

[ruebot]

I'm able to create a successul PDF SP object, and it has a PDF/A datastream, so we're good to go there.

If you want to rebase/squash this all down to a single commit, take a look at your log/history. I have an alias for git history that comes in really handy. The count the number of commits back to the original commit you want to rebase to. Then do git rebase -i HEAD~11 (if you have 11 commits to you want to rebase on top of the original commit. Then, depending on what editor you have tied to your gitconfig, you'll be take to a screen with a list of a commits with pick next to all of them. Leave of them of your choosing like that, and then put squash next to the rest of them. Once you save and exit that file, you'll be take to another screen that asks for a commit message. Commit all of them out except for the one you want, then save and quit. From there, you'll just need to push. But, you'll need to do a force push. So, git push -f origin 7.x should take care of that for you. Once that happens, we should only see one commit here.

[axfelix]

I'd already tried that, except that I had merge issues for like six out of the eleven commits, which seemed so bizarre and unnecessary I just attempted to skip them, but then I was afraid to force push at the end so I did a pull first and, I think, failed to accomplish anything. I'll try again in a bit. Glad the actual Gs call is working; I think that functionality is now <20% of the time I've spent trying to fix this!

[axfelix]

well, I think the force push finally got me over the hump, but I have no idea why all of those old commits are now showing up here, and I'm a little paranoid about having broken something with that rebase because I did just skip a bunch of merge conflicts since it seemed implausible to have to reconcile them all in order, and this commit still contains a few weird unnecessary syntax changes to other files that were probably the result of running drush coder format on top of php tidy (I probably should've rolled back the php tidy commit). I, uh, think this is fine now, though.

[ruebot]

...uh...yeah...things definitely blew up there.

[axfelix]

should I just try to redo this from scratch at this point?

[ruebot]

If you have it stashed away safe somewhere, then yeah. I'd definitely close this PR, delete your repo, fork, create a branch 7.x-ISLANDORA-1130, push and do a PR.

[axfelix]

k! I'm trying to not spend too much time on this at once for the sake of my sanity, so expect it tomorrow or weds.

[ruebot]

We have until code freeze in March 😉

[axfelix]

I know, but we're pretty far into albatross territory for my todo list at this point!