Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: ISLANDORA-2064
Related PR: Islandora/islandora_paged_content#138
What does this Pull Request do?
Add more context to access check, permitting overrides.
What's new?
islandora_object_access()
instead ofuser_access()
for access control to allow things to be influenced from our access hooks.How should this be tested?
Primarily, regression testing: Things should work as they did.
Simple test module exposing a block allowing the permissions to be denied via our hooks: https://github.com/adam-vessey/islandora_2064_test
Additional Notes:
Interested parties
@DiegoPino (as component manager)