Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object context for permission. #197

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

adam-vessey
Copy link
Contributor

@adam-vessey adam-vessey commented Sep 20, 2017

JIRA Ticket: ISLANDORA-2064

Related PR: Islandora/islandora_paged_content#138

What does this Pull Request do?

Add more context to access check, permitting overrides.

What's new?

  • Use islandora_object_access() instead of user_access() for access control to allow things to be influenced from our access hooks.

How should this be tested?

Primarily, regression testing: Things should work as they did.

Simple test module exposing a block allowing the permissions to be denied via our hooks: https://github.com/adam-vessey/islandora_2064_test

Additional Notes:

  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Unlikely, but it is possible.

Interested parties

@DiegoPino (as component manager)

@qadan
Copy link

qadan commented Sep 21, 2017

Successfully smoke tested this

@DiegoPino
Copy link
Contributor

Ok. Merging this. Feel more than enough time was given, Thanks @adam-vessey

@DiegoPino DiegoPino merged commit 131f63e into Islandora:7.x Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants