7.x islandora 1023 #114
Merged
7.x islandora 1023 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is a commit here form #113 ? |
|
Yeah. They're getting mushed together even though they're separate branches. Not sure why. |
|
It looks like you didn't use a topical branch for #113 so if you created this branch off of your 7.x it would contain the irc commit, this could be handled by branching off of 7.x again and hard resetting to HEAD^1 before making your changes (probably cherrypick from this branch) to the new branch. |
|
Well, there a few of these in the 36 or so pull requests that I did yesterday. So, we'll have to decide whether or not the irc notifications are fine or not. If not, I guess somebody else will have to take care of 1023. |
Merged
bondjimbond
pushed a commit
to bondjimbond/islandora_solution_pack_collection
that referenced
this pull request
Sep 21, 2020
Get rid of explicit redirect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.