-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print nice error message to the screen (without 5.3.3) #363
Conversation
My opinion is if we are going to allow failures for PHP 5.3.3, its probably better to just remove it from the build matrix all together. Its failing and we aren't planning to fix it, so spending the travis time building it just to make a broken build doesn't seem worth it to me. |
I will have to agree. Committers call agreement or do we aim for an
executive order?
El El mié, 24 de abr. de 2019 a las 09:40, Jonathan Green <
[email protected]> escribió:
My opinion is if we are going to allow failures for PHP 5.3.3, its
probably better to just remove it from the build matrix all together. Its
failing and we aren't planning to fix it, so spending the travis time
building it just to make a broken build doesn't seem worth it to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABU7ZZ26C4YM2ZFLWCVBZATPSBPOPANCNFSM4HH6PK6A>
.
--
Diego Pino Navarro
Digital Repositories Developer
Metropolitan New York Library Council (METRO)
|
I feel like we've talked about 5.3.3 on at least a few calls. Was anyone speaking vehemently in its defense? |
@bondjimbond @DiegoPino If committers agree, there's no need for an executive order. And it's been long enough now that maybe 5.3.3 is no longer attractive to those that were clinging on. Or at least maybe they'd be willing to compromise with the allowed fail. So it's still worth a shot IMO. However, in the event that maybe we need a nudge from higher up the chain, the TAG is meeting soon and this issue has been put on the agenda: https://github.com/Islandora/islandora/wiki/TAG-Meeting---April-26-2019 |
Tag it is then!
El El mié, 24 de abr. de 2019 a las 10:46, dannylamb <
[email protected]> escribió:
@bondjimbond <https://github.com/bondjimbond> @DiegoPino
<https://github.com/DiegoPino> If committers agree, there's no need for
an executive order. And it's been long enough now that maybe 5.3.3 is no
longer attractive to those that were clinging on. Or at least maybe they'd
be willing to compromise with the allowed fail. So it's still worth a shot
IMO.
However, in the event that maybe we need a nudge from higher up the chain,
the TAG is meeting soon and this issue has been put on the agenda:
https://github.com/Islandora/islandora/wiki/TAG-Meeting---April-26-2019
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABU7ZZ47BSNV6CBA3HUW62LPSBXFBANCNFSM4HH6PK6A>
.
--
Diego Pino Navarro
Digital Repositories Developer
Metropolitan New York Library Council (METRO)
|
My proposal with this, is that we always "talk" about removing extremely out-of-date software but we never do it. This allows us a two-step approach.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect. Merging in 24
This is #362 (the cleaning house remix).
Reminder: PHP 5.3 became End Of Life 4 years, 8 months ago.
https://www.php.net/eol.php
Interested parties
@DiegoPino, @jonathangreen @Islandora/7-x-1-x-committers and anyone with a valid reason to not allow 5.3.3 to fail.