Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete context.context.files_in_fedora.yml #53

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Conversation

dannylamb
Copy link
Contributor

GitHub Issue: Part of this mess: Islandora-Devops/isle-dc#132

What does this Pull Request do?

Deletes a context we no longer need b/c we don't use Gemini anymore.

What's new?

One less context. It wasn't hurting anything just laying around, but I'm trying to be tidy here.

Does this warrant an update hook to delete it from existing sites? Or should I just add instructions to do it in the release notes? @Islandora/8-x-committers ?

@dannylamb
Copy link
Contributor Author

Sounds prudent to me

@dannylamb
Copy link
Contributor Author

Linking this to Islandora/documentation#1848 since that's how I discovered that this needs to be deleted.

@dannylamb
Copy link
Contributor Author

@Islandora/8-x-committers Bumpin' this for the release.

@seth-shaw-unlv is out on 🌴 , so I need someone else to step up and get this in.

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled in this PR, verified the context was deleted. tested adding an item with an original file and verified that the original file still made it to fedora. seems good.

@dannylamb
Copy link
Contributor Author

can haz merge?

@elizoller elizoller merged commit 0d9a59a into 8.x-1.x Jul 15, 2021
@seth-shaw-unlv seth-shaw-unlv deleted the less-gemini branch September 1, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants