Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies. #882

Closed
wants to merge 73 commits into from
Closed

Update dependencies. #882

wants to merge 73 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jul 12, 2022

GitHub Issue: (link)

Update dependency versions to newer modules.

What does this Pull Request do?

This shouldn't do much except

  • install migrate_plus v6 which is functionally the same as 5 according to the release notes
  • install a newer codesniffer if you're ever using this module's require-dev's.

How should this be tested?

It should still install through composer, and the site should function as usual. I tested to the best of my ability; the migrate module seems to be working with the old migrations still.

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? no-one
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@rosiel
Copy link
Member Author

rosiel commented Jul 13, 2022

needs specific migration testing, since migrate syntax can be fragile between versions.

@jordandukart
Copy link
Member

@rosiel are there any bumps in here that are still needed given that time has passed, things have already been bumped in the composer.json a bit and the fact that this is conflicting now?

@rosiel
Copy link
Member Author

rosiel commented Dec 14, 2022

🤦 another git rebase nightmare. Sorry. I'll try again (and most of them have been done, you're right.)

@rosiel rosiel closed this Dec 14, 2022
@rosiel rosiel mentioned this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.