Produce error if viewing a media without a source file (Issue-2110) #874
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2110
What does this Pull Request do?
Produces an error message instead of a WSOD when viewing a media where the source file is absent and the fedora URI is set to display.
What's new?
Adds a check to
islandora_entity_view
around the source file to throw an error and return early if it wasn't found.(i.e. Regeneration activity, etc.)? No.
How should this be tested?
drush php:cli
$m = \Drupal::entityTypeManager()->getStorage('media')->load(1);
(replacing "1" with your test media's ID)$f = \Drupal::service('islandora.media_source_service')->getSourceFile($m);
$f->delete();
Interested parties
@Islandora/committers