Added islandora_advanced_search module. #824
Conversation
|
Niiiiiiiice. Thx @nigelgbanks ! |
|
|
||
| ## Introduction | ||
|
|
||
| This module creates an several blocks to support searching as well as enables the use of Ajax. |
There was a problem hiding this comment.
Should be sorted now.
I'll do those both on Monday most likely. |
| $configuration, | ||
| $plugin_id, | ||
| $plugin_definition, | ||
| $container->get('request_stack')->getMasterRequest(), |
There was a problem hiding this comment.
As per discussion in Slack this is 7.3 specific feature: https://wiki.php.net/rfc/trailing-comma-function-calls.
| $plugin_definition, | ||
| $container->get('plugin.manager.search_api.display'), | ||
| $container->get('form_builder'), | ||
| $container->get('request_stack')->getMasterRequest(), |
There was a problem hiding this comment.
| */ | ||
| public static function create(ContainerInterface $container) { | ||
| return new static( | ||
| $container->get('request_stack')->getMasterRequest(), |
There was a problem hiding this comment.
| $container->get('router'), | ||
| $container->get('path_processor_manager'), | ||
| $container->get('current_route_match'), | ||
| $container, |
There was a problem hiding this comment.
nigelgbanks
force-pushed
the
8.x-1.x-advanced-search
branch
from
6b310c0 to
84de729
Compare
Should be done now. |
|
@jordandukart I fixed the incompatibilities you highlighted. I tried to find a tool that could automate this check for me, but neither https://vfac.fr/projects/php7compatibility or its latest version from source https://github.com/PHPCompatibility/PHPCompatibility could find the issue. Do you know of a tool that could automate this check? I'd like to integrate something into IDE packaged with Isle Islandora-Devops/isle-buildkit#130 so that it can happen automatically. |
|
Also sorry it took a month to get to this, Isle swallowed almost all of my time during that last month. |
|
@ajstanley are you still looking at this one? or does it need another set of 👀 ? |
|
All looking good. Merged. |
|
@ajstanley @nigelgbanks Good stuff. However, needs search and replace of |
What does this Pull Request do?
Adds a new optional module that allows for include/exclude facets, collection searching, advanced search, etc.
Most of features are covered in this demo:
How should this be tested?
No configuration is provided as part of the module as it will depend on the users content types, fields etc. The
README.mddocuments how it can be configured.Install and mess around more or less.
Additional Notes:
Minimal CSS is provided with the module, the assumption is that will largely be handled by the theme as it's gonna differ from site to site.
No new dependencies are added if you consider the dependencies that
islandora_defaultshas.Interested parties
@Islandora/8-x-1-x-committers