Issue 1291

[dannylamb]

All work done by @ajstanley. I just migrated it over from Islandora-CLAW/islandora.

Original PR: Islandora/documentation#175

GitHub Issue: (Islandora/documentation#1291)

What does this Pull Request do?

Odd failures will occur if a user who has not been assigned the hardcoded fedoraAdmin role
attempts to add a media type that is set to save to the fedora filesystem.

What's new?

This fix adds a filter to the controller so the user will not see media types they cannot use.

How should this be tested?

Create a user with the Administrator role, but without fedoraAdmin role.
Log in or masquerade as that user.
Have at least one media type that saves to fedora and one that does not.
(This setting is found under the field settings for the file field in the Media type).
Navigate to the Add Media button on the Media tab of any object.
You should only see media types that do NOT save to fedora.

Interested parties

@Islandora-CLAW/committers

[elizoller]

@ajstanley I can test this once the conflict is resolved

[ajstanley]

I'm going to have to redo this one - The merge fails because of all the changes in the last 6 months or so, and the branch I was merging from has changes also. (Plus it was from Roblib, and I'm not there anymore) I'll grab the patches and apply them to a fresh branch, test, and re-submit.

…

On Wed, Aug 19, 2020 at 2:27 PM Eli Zoller ***@***.***> wrote: @ajstanley <https://github.com/ajstanley> I can test this once the conflict is resolved — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADY2J74XU4DMBBHGSSTBMTSBQDPFANCNFSM4JA7ZXKA> .

-- Alan Stanley Developer and Training Specialist Agile Humanities

[DonRichards]

Is this still a relevant pull request or can this be closed?

[ajstanley]

You can kill this one. It was only ever meant to be temporary until the fedoraAdmiin role isn't hard-coded anymore.

…

On Mon, Aug 9, 2021 at 3:56 PM Don Richards ***@***.***> wrote: Is this still a relevant pull request or can this be closed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADY2J6P3EPR36RIALEQK33T4AQG3ANCNFSM4JA7ZXKA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

-- Alan Stanley Interim Executive Director Spinal Cord Injury, PEI ☎ *902-393-0017*