-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated production install instructions #2225
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is confusing me a little bit. Is the codebase github repository separate from the isle-dc one or are you committing them into one repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've committed them together in one repo. I just changed the remote URL to point to my private repo instead of Isle-DC and then started making modifications. So my repo has the Isle-DC history up to the point where I started my site. I don't plan to pull any more changes from Isle-DC after that point, and instead will be making my own customizations, but you could continue to pull from Isle-DC if you wanted to.
I also changed the .gitignore to not ignore the entire codebase folder, but still ignore the web and vendor directories. This is basically the equivalent of combining Isle-DC and the starter site into one git repo, but will quickly diverge into my own set of modules, modifcations to the Makefile, etc.
Doing things this way lets me clone my whole project locally or in production and use the Isle-DC makefile to quickly spin up the site based on the composer.json file in my codebase directory. It's also helpful to have them together for CI/CD if you want to do things like building the image when you make changes to the codebase folder.
That wording was somewhat unclear, so I have taken another pass at that section. Hopefully it makes more sense now, but please let me know if it needs further clarification.