Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-a-demo.md #2204

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update install-a-demo.md #2204

merged 1 commit into from
Jan 18, 2023

Conversation

rebeccapower
Copy link
Contributor

@rebeccapower rebeccapower commented Jan 17, 2023

Added details for a Windows 10 fix I encountered but couldn't find info for online.

Purpose / why

What changes were made?

Verification

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Added details for a Windows 10 fix I encountered but couldn't find info for online.
@DonRichards DonRichards self-requested a review January 18, 2023 18:06
@DonRichards
Copy link
Member

This makes sense but there is almost no one to test/verify this. Because this is a doc change and should work we decided (tech call) that this should be merged.

@DonRichards DonRichards merged commit 218fdfa into Islandora:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants