Update CONTRIBUTING.md #2159
Merged
Update CONTRIBUTING.md #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Purpose / why Changes made according to collaborative doc [here](https://docs.google.com/document/d/1h2KRHNtmyEf3hV5zeBF1O2AMx_WH1b0NWe3nRo5u3tk/edit?usp=sharing) to make contributing guidelines clearer. ## What changes were made? - Add all community channels - creating "Github Issues" to replace "Report a Bug", "Documentation", "Request a new feature", "Use Cases" sections - creating "Github Pull Requests" to replace "Contribute code" section ## Verification * Linked LSAP process needs to be reviewed * This version does not include a ["Create a pull request"](https://islandora.github.io/documentation/contributing/CONTRIBUTING/#create-a-pull-request) section. The instructions there had specific naming for branches and PRs - is this still practiced? Does creating a fork need to be covered here/on this page, or should there be another tutorial page for this? ## Interested Parties @rosiel @ysuarez * @Islandora/documentation * @Islandora/committers ## Checklist ### Pull-request Reviewer Pull-request reviewer should ensure the following: * [ ] Does this PR link to related [issues](https://github.com/Islandora/documentation/issues/)? * [ ] Does the proposed documentation align with the [Islandora Documentation Style Guide](https://islandora.github.io/documentation/contributing/docs_style_guide/)? * [ ] Are the changes accurate, useful, free of typos, etc? ### Person Merging The person merging should ensure the following: * [ ] Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see [How To Build Documentation](https://islandora.github.io/documentation/technical-documentation/docs-build/).) * [ ] If pages are renamed or removed, have all internal links to those pages been fixed? * [ ] If pages are added, have they been linked to or placed in the menu? * [ ] Did the PR receive at least one approval from a committer, and all issues raised have been addressed?
adam-vessey
reviewed
Aug 31, 2022
|
+1 for removing 'create a PR' section. Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / why
Changes made according to collaborative doc here to make contributing guidelines clearer.
What changes were made?
Verification
Interested Parties
@rosiel @ysuarez
Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:
Person Merging
The person merging should ensure the following: