Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PDX - Related to #226 #231

Closed
ruebot opened this issue May 18, 2016 · 3 comments
Closed

Refactor PDX - Related to #226 #231

ruebot opened this issue May 18, 2016 · 3 comments
Assignees
@ruebot
Milestone
Community Sprint ...

Comments

@ruebot
Copy link
Member

ruebot commented May 18, 2016

This should make it easier for @bryjbrown to work on #222
@ruebot ruebot added the PDX label May 18, 2016
@ruebot ruebot added this to the Community Sprint - 07 milestone May 18, 2016
@ruebot
Copy link
Member Author

ruebot commented May 18, 2016

@whikloj @DiegoPino I'll leave this to y'all as time permits.

@bryjbrown hope this helps you out. You should be able to add your service similar to how the CollectionService is setup. You might want also consider some additional refactoring like @whikloj is doing here. Or, you, @whikloj and @DiegoPino can tell me to update this PR to do that too 😄

@ruebot ruebot self-assigned this May 18, 2016
DiegoPino pushed a commit to islandora-deprecated/pdx that referenced this issue May 19, 2016
@ruebot @DiegoPino
Issue 231 (#1)
16e3568 
* Refactor PDX post move; Related to Islandora/documentation#226; Address Islandora/documentation#231
@ruebot
Copy link
Member Author

ruebot commented May 19, 2016

Resolved with islandora-deprecated/pdx@16e3568

@ruebot ruebot closed this as completed May 19, 2016
@ruebot
Copy link
Member Author

ruebot commented May 19, 2016

@br2490 @bryjbrown it's 🎉 time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruebot ruebot

Labels
None yet
Projects
None yet
Milestone
Community Sprint - 07
Development

No branches or pull requests
1 participant
@ruebot