-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EDTF field for 2018 spec compliance #19
Conversation
added EDTFUtils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works - I tested that it successfully transformed my 2012-style ETDF to 2018-ese.
Ah! Hold up. Yes, it works for the dates; however, I didn't update EDTFConverter to expect 2018 compliant dates; it still assumes older ones. |
Would you mind reviewing again, @rosiel, so we can get this merged? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again, ran it through some paces. Looks good!
Please feel free to merge when ready @rosiel. No 24h wait period here 🎉 |
GitHub Issue: /Islandora-CLAW/CLAW/issues/995
What does this Pull Request do?
Fixes the Widget and Formatter for the EDTF Field Type to match the 2018 spec.
What's new?
How should this be tested?
drush updb -y
)Interested parties
@Islandora-CLAW/committers