Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora resource converter #1

Merged
merged 6 commits into from
Apr 3, 2017

Conversation

dannylamb
Copy link
Contributor

@dannylamb dannylamb commented Apr 3, 2017

GitHub Issue: Part of Islandora/documentation#578

What does this Pull Request do?

Adds a route parameter converter in silex to take a path and turn it into a response from Fedora.

What's new?

The converter and basic repo set up.

How should this be tested?

Can't, really. Merge it after review and then test it by testing Islandora/Crayfish#18, which uses this code.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-CLAW/committers

Copy link
Member

@ruebot ruebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small tweaks, and then we're good to merge.

@@ -0,0 +1,77 @@
# Welcome!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannylamb you need to grab a more recent CONTRIBUTING.md. This one has all the 7.x-2.x stuff in it still.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np. i think I stole this from Crayfish or Chullo somewhere, so I'll pull from another source and update those as well.

composer.json Outdated
{
"name": "Islandora Foundation",
"email": "[email protected]"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannylamb might as well add yourself as a maintainer here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was strategically leaving that blank, but may as well :P

@dannylamb
Copy link
Contributor Author

dannylamb commented Apr 3, 2017

Just pushed up a commit for Islandora/Crayfish#18 to update its contributing md as well.

@dannylamb
Copy link
Contributor Author

Ah.... getting some seriously weird Travis action going on. Builds error immediately without going through setup. Maybe we need to get a .travis.yml file in there and then it will start to behave?

@ruebot
Copy link
Member

ruebot commented Apr 3, 2017

@dannylamb yeah, toss a .travis.yml in there, and just have it test for coding standards at the very least for now.

@dannylamb
Copy link
Contributor Author

@ruebot there's one in this pull to do just that. there's not one in the repo right now, and i think that's the problem. but i dunno i've never seen Travis behave that way before.

@ruebot
Copy link
Member

ruebot commented Apr 3, 2017

facepalm

@dannylamb
Copy link
Contributor Author

@ruebot looks lke travis has righted himself. i see i've got a line ending problem to deal with. just a moment.

@ruebot
Copy link
Member

ruebot commented Apr 3, 2017

@dannylamb how about I merge this, and we create a ticket to update the line endings script to ignore vendor dir?

@dannylamb
Copy link
Contributor Author

ah... hang on. i'm knee deep in find arguments right now. i'll have it shortly.

@dannylamb
Copy link
Contributor Author

@ruebot we're green now. i'll make the issue for updating every other line ending script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants