Expose PHP variables to make them easier to adjust #171
Conversation
There was a problem hiding this comment.
Looks solid, existing users will get an error as there is no default value in the *.yml files. Though I don't think it's too much burden for them to check and update their .env when they pull to the latest and compare it against the sample.env.
I think though the same configs need to be added to https://github.com/Islandora-Devops/isle-dc/blob/development/docker-compose.code-server.yml as well. If the user is using the code-server it intercepts the traffic that would normally go to drupal, and users would likely be confused if they when to the status page / phpinfo in Drupal and didn't see their expected values for memory and what not.
|
@nigelgbanks I believe I addressed that with the latest commit - let me know if it's in the wrong place. |
|
@bondjimbond if you could add it to the |
|
@nigelgbanks Done. Does that address everything? |
|
Fantastic thanks! |
Resolves #170: Adds PHP memory limit and file upload maximum variables to
sample.envanddocker-compose.drupal.ymlso that they can be easily adjusted.