Issue 224 Fixed - Dead code removed #241
Conversation
| ENV \ | ||
| HYPERCUBE_FCREPO_URL=fcrepo/fcrepo/rest \ | ||
| HYPERCUBE_LOG_LEVEL=info | ||
| ENV HYPERCUBE_LOG_LEVEL=info |
There was a problem hiding this comment.
There was a problem hiding this comment.
If this isn't needed, it should be removed from the config.yaml.tmpl file as well.
There was a problem hiding this comment.
Apologies for delay. Removed now
There was a problem hiding this comment.
lol, turns out it was supposed to be there. https://islandora.slack.com/archives/CM6F4C4VA/p1668431519198479
milliner/README.md
Outdated
| @@ -13,7 +13,7 @@ additional settings, volumes, ports, etc. | |||
| | Environment Variable | Confd Key | Default | Description | | |||
| | :------------------- | :------------------- | :----------------- | :------------------------------------------------------------------------------------------------ | | |||
| | MILLINER_DRUPAL_URL | /milliner/drupal/url | drupal:80 | Drupal URL | | |||
| | MILLINER_FCREPO_URL | /milliner/fcrepo/url | fcrepo/fcrepo/rest | Fcrepo Rest API URL | | |||
| | MILLINER_FCREPO_URL | /milliner/fcrepo/url | fcrepo:8080/fcrepo/rest | Fcrepo Rest API URL | | |||
There was a problem hiding this comment.
Just noticed now, but the URL variables for the microservices in the README.md files are missing the prefixed http://, so this should probably be fixed across all microservices.
There was a problem hiding this comment.
Also, can you make sure the alignment of the tables are kept? This can be done with https://marketplace.visualstudio.com/items?itemName=yzhang.markdown-all-in-one if using VS Code, and I'm sure other auto-formatters exist for other IDEs.
There was a problem hiding this comment.
Roger that! Will do.
There was a problem hiding this comment.
Not sure if I did this right in terms of alignment. I do use that auto-formatter but it seemed a bit thick on moving things around properly. Or perhaps its operator was? 😄
There was a problem hiding this comment.
Also tested this on my local. no issues discovered
No description provided.