Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting newlines on template for allowed external content in fcrepo #150

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Correcting newlines on template for allowed external content in fcrepo #150

merged 2 commits into from
Jul 1, 2021

Conversation

dannylamb
Copy link
Member

Adding - to force the template to make each allowed host on its own line.

RDF for files not stored in Fedora were failing to index due to needing both http and https domains allowed.

@dannylamb dannylamb mentioned this pull request Jun 28, 2021
Merged
@seth-shaw-unlv
Copy link

Looks like this might keep failing until #149 is merged. See https://github.com/Islandora-Devops/isle-buildkit/runs/2933265016?check_suite_focus=true#step:5:5762

nigelgbanks
nigelgbanks approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@nigelgbanks nigelgbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as described.

@nigelgbanks nigelgbanks merged commit 384e0a4 into main Jul 1, 2021
@nigelgbanks nigelgbanks deleted the fix-external-content-rdf-indexing branch July 1, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelgbanks nigelgbanks nigelgbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannylamb @seth-shaw-unlv @nigelgbanks