Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset drupal_composer_dependencies so as to not separately require drush. #274

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jan 19, 2024

GitHub Issue: #269

Past issue that failed to account for this: #271

What does this Pull Request do?

Reverts a line that removes the default geerlingguy drupal role's tendency to install drush 10. We already install drush through having it in the Starter Site's composer.json so we don't need to do this.

A brief description of what the intended result of the PR will be and/or what
problem it solves.

What's new?

Un-breaks the playbook.

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

  • Run the playbook now. It should fail during the "islandora_build_base_box=false" step, when doing Install dependencies with composer require
  • With this PR, it should go through fine.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

Copy link
Contributor

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@seth-shaw-asu seth-shaw-asu merged commit 573e2e9 into dev Jan 30, 2024
@seth-shaw-asu seth-shaw-asu deleted the dont-install-drush branch January 30, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants