Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-CLAW #234

Merged
merged 4 commits into from
Oct 21, 2022
Merged

de-CLAW #234

merged 4 commits into from
Oct 21, 2022

Conversation

seth-shaw-asu
Copy link
Contributor

@seth-shaw-asu seth-shaw-asu commented Oct 17, 2022

GitHub Issue: N/A

What does this Pull Request do?

Removes references to CLAW and Islandora 8.

What's new?

Removes references to CLAW and Islandora 8.

How should this be tested?

Read through and make sure I didn't botch any URLs, etc.

Additional Notes:

I left the namespaces file claw.cnd as I felt it didn't harm anything and I didn't want to miss a reference to it. Decided to do it after all.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 lines referenced should be updated. I also found several other uses of "claw" in the ansible code, but also in

roles/internal/webserver-app/tasks/solr.yml:# Solr server configuration should go into the solr playbook: https://github.com/Islandora-Devops/claw-playbook/blob/dev/solr.yml

@seth-shaw-asu seth-shaw-asu requested a review from whikloj October 20, 2022 15:34
@seth-shaw-asu
Copy link
Contributor Author

seth-shaw-asu commented Oct 20, 2022

Helps to save your open files before doing the git add... 🙄

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and still builds.

@whikloj whikloj merged commit e78c4de into Islandora-Devops:dev Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants