Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composer drupal optimizations #221

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Remove composer drupal optimizations #221

merged 1 commit into from
Jul 14, 2022

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jul 11, 2022

GitHub Issue: #217

We found that trying to allow composer plugins manually didn't work, so since Drupal has updated their recommended project, the only plugin causing problems is the composer optimizations, which was (AFAIK) created for Composer 1.

What does this Pull Request do?

remove zaporylie/composer-drupal-optimizations:^1.1

What's new?

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? removes one.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? may slow down??

How should this be tested?

Without this PR: vagrant up fails when installing composer dependencies because composer does not allow plugins
with this PR: Vagrant up (or provision) completes successfully.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag @alxp

@jordandukart jordandukart requested a review from alxp July 13, 2022 17:45
@alxp alxp merged commit 311aa21 into dev Jul 14, 2022
@rosiel rosiel deleted the rosiel-patch-1 branch September 19, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants