-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
@DiegoPino @whikloj y'all good with me merging this? That way we can start getting codecov feedback. |
sets up PDX for codecov |
@bryjbrown you'll want to add something along these lines to the |
We can merge this, but I'd say wait and see if @bryjbrown has time to write a test or two. No need to rush on it in this state. Codecov would just tell us what we already know 0% covered 😊 |
@bryjbrown if you can add those PHPUnit lines that @ruebot pointed to here. We can merge this. |
@whikloj @ruebot Gitlords, is there any way I can clone a copy of the original repo from this PR, or should I re-fork/add in the changes from this PR/submit a new PR? I figure there must be a way to have one local repo that can make branches from multiple "origins" (remotes?), but this is definitely a step up in complexity. |
@bryjbrown ouch. you didn't need to do that 😢 -- next time you should be able to pull it off with git remotes, and branching. If you need a hand with that, more than happy to help. @whikloj want to just merge this, and I can come back through and take care of addressing my comments. |
@bryjbrown ...do you still have a copy of this branch locally? Or did you delete that too? |
@ruebot I do! Anything I can do with that? |
@bryjbrown do you remember the branch name you used to make this PR? hopes it wasn't master |
This PR is superceded by #10 |
This PR adds:
after_success
hook and README badge)This is a stab towards resolving #260 and #280.