Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Add test scaffolding #9

Closed
wants to merge 3 commits into from
Closed

Add test scaffolding #9

wants to merge 3 commits into from

Conversation

bryjbrown
Copy link
Contributor

This PR adds:

  • PHPUnit scaffolding (phpunit.xml.dist file and /test/bootstrap.php, enough to get the PHPUnit CLI test runner to execute with 0 tests)
  • Codecov.io integration (.travis.yml after_success hook and README badge)

This is a stab towards resolving #260 and #280.

@ruebot
Copy link
Contributor

ruebot commented Jun 27, 2016

@DiegoPino @whikloj y'all good with me merging this? That way we can start getting codecov feedback.

@ruebot
Copy link
Contributor

ruebot commented Jun 27, 2016

sets up PDX for codecov

@ruebot
Copy link
Contributor

ruebot commented Jun 28, 2016

@bryjbrown you'll want to add something along these lines to the .travis.yml

@whikloj
Copy link
Contributor

whikloj commented Jun 28, 2016

We can merge this, but I'd say wait and see if @bryjbrown has time to write a test or two. No need to rush on it in this state. Codecov would just tell us what we already know 0% covered 😊

@whikloj
Copy link
Contributor

whikloj commented Jul 4, 2016

@bryjbrown if you can add those PHPUnit lines that @ruebot pointed to here. We can merge this.

@bryjbrown
Copy link
Contributor Author

bryjbrown commented Jul 5, 2016

@whikloj @ruebot
I deleted the bryjbrown/pdx repo this PR was made from when I forked br2490/pdx to start working on it. Now I'm not sure what to do.

Gitlords, is there any way I can clone a copy of the original repo from this PR, or should I re-fork/add in the changes from this PR/submit a new PR? I figure there must be a way to have one local repo that can make branches from multiple "origins" (remotes?), but this is definitely a step up in complexity.

@ruebot
Copy link
Contributor

ruebot commented Jul 5, 2016

@bryjbrown ouch. you didn't need to do that 😢 -- next time you should be able to pull it off with git remotes, and branching. If you need a hand with that, more than happy to help.

@whikloj want to just merge this, and I can come back through and take care of addressing my comments.

@ruebot
Copy link
Contributor

ruebot commented Jul 5, 2016

@bryjbrown ...do you still have a copy of this branch locally? Or did you delete that too?

@bryjbrown
Copy link
Contributor Author

@ruebot I do! Anything I can do with that?

@ruebot
Copy link
Contributor

ruebot commented Jul 5, 2016

@bryjbrown do you remember the branch name you used to make this PR? hopes it wasn't master

@bryjbrown
Copy link
Contributor Author

This PR is superceded by #10

@bryjbrown bryjbrown closed this Jul 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants