Change bytes property on SigningKeypair to return a borrow of the int… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltfred
approved these changes
Apr 29, 2019
coltfred
pushed a commit
that referenced
this pull request
Apr 30, 2019
* Api naming and visibility changes (#57) * Api naming and visibility changes * api::Api -> api::Recrypt * api_480::Api480 -> api_480::Recrypt480 * ApiErr -> RecryptErr; RecryptErr is now publicly exported from the api/api_480 namespace * api and api_480 PrivateKey::ENCODED_SIZE_BYTES now public * [#63] Add prelude for easier importing (#64) * [#65] update CI to rust 1.33.0; update proptest to ~0.9 (#66) * Add to_private_key to DerivedSymmetricKey (#70) * * added `to_private_key` to `DerivedSymmetricKey` * make `PublicKey` arguments in public API borrows * Update 480 bit api, tests and benches * * added to_private_key to Recrypt480 * remove to_private_key from Recrypt480 * Move derive_private_key onto the apis * Add as_vec function to make it easier to get to vec iterators * Throw away the most significant bytes instead of the least, because it seems to make more sense to me * Add known private key test for api480 * formatting * Remove printlns * Address Clint's concerns * The hashable instance was unused. Remove it and add a different one. (#71) * Change bytes property on SigningKeypair to return a borrow of the internal bytes (#72) * releasing v0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ernal bytes