Add quick_error to all of our error ADTS #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
coltfred
commented
Oct 18, 2018
coltfred
commented
- Added quick_error to error adts. This results in us having the Error trait implemented without writing them ourselves. See the documentation for details.
- All public errors now have informative messages, but also contain links to the sub errors that caused them.
clintfred
approved these changes
Oct 19, 2018
src/internal/mod.rs
Outdated
| @@ -819,7 +809,7 @@ impl<FP: Field + NonAdjacentForm> ReencryptionKey<FP> { | |||
| /// | |||
| /// # Return | |||
| /// ReencryptedValue - if the value could be successfully reencrypted | |||
| /// - Left(SignatureFailed|ReencryptionKeyIsCorrupt) - if the signatures weren't valid. | |||
| /// - Left(InvalidEncryptedMessageSignature|ReencryptionKeyIsCorrupt) - if the signatures weren't valid. | |||
There was a problem hiding this comment.
I guess Left isn't technically true here...
Do we have a standard way of documenting errors?
There was a problem hiding this comment.
We should say Err instead. I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.